Implements prefix lookups for DNS TTL #4605
Conversation
This will fix hashicorp#4509 and allow forinstance lb-* to match services lb-001 or lb-service-007
|
@mkeeler Hello Matt, Do you think you might have a look ? Best Regards |
|
@pearkes Do you think it could be included? (it a quite simple patch, safe in terms of ascending compatibility and will really help having good performance for DNS usages with many many services) |
|
@mkeeler do you think you can review? This change is very backwards compatible and it would really help us to merge this in order to reduce significantly the load generated by DNS requests on Consul server. Kind regards |
|
@pearkes Do you think you might have a look? The change is pretty simple but would really help for people having large number of services. It is also very good at ascending compatibility since it simply allow the use of * not only for '*' but with any prefix. Kind regards |
This will fix hashicorp#4509 and allow forinstance lb-* to match services lb-001 or lb-service-007 Added unit tests with new TTLs prefix Fixed unstable unit tests Use Radix lookup for default key '*' on TTL lookups Added documentation for DNS wildcard matches with prefix Better documentation about DNS TTL cache mechanism
|
@banks Thank you for the review, all your comments resolved in next patch |
This will fix #4509 and allow forinstance lb-* to match services lb-001 or lb-service-007.
This will fix #4509 and allow for instance
lb-*to match serviceslb-001orlb-service-007When not adding
*at the end, the existing behavior is kept, meaning strict check.