Support "exec" in foreign datacenters #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armon
added a commit
that referenced
this pull request
Jan 7, 2015
Support "exec" in foreign datacenters
|
Just hit this. Thanks for fixing Armon! In case somebody plugs the error message in to Google ... this is what it looks like: [centos@dc1-host1 ~]$ consul consul exec -datacenter="dc1" whoami [centos@dc1-host1 ~]$ consul consul exec -datacenter="dc2" whoami |
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
* Update CONTRIBUTING.md with new acceptance tests info * Fix race condition in terraform templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was possible to specify a datacenter with
-datacenterbut setting anything other than the local datacenter would fail. This PR properly handles remote data centers. In a local datacenter, we associate a session with the node that is invoking exec. In a remote datacenter, we associated a session with a Consul server in the remote datacenter. Additionally, we make use of the newSessionDeletebehavior to ensure garbage is cleaned up, and a session TTL for cases where we fail to explicitly destroy a session. Fixes #313