Improve startup message to avoid confusing users when no error occurs #5896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several times, some users not very familiar with Consul get confused by error message at startup: `[INFO] agent: (LAN) joined: 1 Err: <nil>` Having `Err: <nil>` seems weird to many users, I propose to have the following instead: * Success: `[INFO] agent: (LAN) joined: 1` * Error: `[WARN] agent: (LAN) joined: %d Err: ERROR`
suggestion from @i0rek to improve error message Co-Authored-By: Hans Hasselberg <me@hans.io>
|
@i0rek DONE in next patch |
|
Damned unstable tests |
pierresouchay
force-pushed
the
no_error_message_on_success
branch
from
0a604ff
to
f0483f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several times, some users not very familiar with Consul get confused
by error message at startup:
[INFO] agent: (LAN) joined: 1 Err: <nil>Having
Err: <nil>seems weird to many users, I propose to have thefollowing instead:
[INFO] agent: (LAN) joined: 1[WARN] agent: (LAN) joined: %d Err: ERROR