Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket service checks #6015

Open
sylr opened this issue Jun 25, 2019 · 1 comment
Open

Websocket service checks #6015

sylr opened this issue Jun 25, 2019 · 1 comment
Labels
theme/health-checks Health Check functionality type/enhancement Proposed improvement or new feature
Milestone

Comments

@sylr
Copy link

sylr commented Jun 25, 2019

Feature Description

2 new types of checks:

  • Websocket Client
  • Websocket Server (if possible)

Those checks would fail as soon as the service terminates the websocket or does not write anything for a configurable amount of time.

In Websocket Client consul would established the connection to the service like an HTTP check. In Websocket Server consul would run a websocket server and the service would be the one establishing the connection to the service.

@pearkes pearkes added type/enhancement Proposed improvement or new feature theme/health-checks Health Check functionality labels Jun 28, 2019
@pearkes
Copy link
Contributor

pearkes commented Jun 28, 2019

We've added a range of more specialized checks (such as Docker, gRPC) and would likely accept a PR for this but I given the TCP check should satisfy part of this scenario and the script check be a good fallback for more "intelligent" checks, it is unlikely we'll take on this work soon.

@pearkes pearkes added this to the Unplanned milestone Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/health-checks Health Check functionality type/enhancement Proposed improvement or new feature
Projects
None yet
Development

No branches or pull requests

2 participants