fixed: body not closed for non HTTP 200 responses

[imkira]

requireOK function does not close the body for HTTP codes != 200.
Also, currently all calls to requireOK return immediately if there is an error and don't even look at the response.
In the end, no one closes the body so it is leaking.

I don't know if requestOK should be fixed, or if the caller should be fixed.
It seems to me that requireOK should be fixed but I was wondering if the current requireOK implementation is returning the response so that the caller may, say, look at the status code and do something rather than simply returning.
Rather than fixing it I assumed handling on the caller side would be acceptable since we still have to close the body for successful responses and that it just introduces an if resp != nil {} block.

Let me know if this looks good.

[ryanuber]

@imkira good catch! We can see in go's http.Client Do() method, which is what's getting called under the hood, that it either returns nil, err, or resp, nil, so IMO it is probably safe to assume we would never do anything with the response body if err is not nil. I agree though that it wouldn't hurt to just check if the response struct is nil, and if not, at least close the Body to prevent leaking handles. Maybe this belongs in requireOK, which will also ensure that future uses of that method get the same protection.

[imkira]

Thank you @ryanuber .
I also agree that, like http.Client.Do, closing all resources on error (in this case resp.Body) is the right approach.
I am sending a new commit to attempt to fix this issue.
Please let me know if it looks good.

[imkira]

If resp comes from a http.Client.Do, there's no need to do this but I am trying not to take any assumptions.
Even if it comes from http.Client.Do, there should be no harm in closing it here.

[ryanuber]

LGTM, thanks!