Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: allow http match criteria to be applied to routes on services using grpc protocols #6149

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Jul 16, 2019

No description provided.

@rboyer rboyer added this to the 1.6.0-beta3 milestone Jul 16, 2019
@rboyer rboyer requested a review from a team July 16, 2019 21:34
@rboyer rboyer self-assigned this Jul 16, 2019
Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woop!

@banks
Copy link
Member

banks commented Jul 17, 2019

Do you have a TODO to document this along with other smaller stuff? If not maybe a note somewhere would be good.

@rboyer
Copy link
Member Author

rboyer commented Jul 17, 2019

Are you referring to general fuller examples of things you may wish to achieve with L7 stuff? Or more like the changelog?

@banks
Copy link
Member

banks commented Jul 17, 2019

Just somewhere making it discoverable that now gRPC services can have routing controlled - perhaps an example of re-routing a specific RPC path?

@rboyer rboyer merged commit d7a5158 into release/1-6 Jul 17, 2019
@rboyer rboyer deleted the l7-router-grpc branch July 17, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants