server: strip local ACL tokens from RPCs during forwarding if crossing datacenters #7419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeler
approved these changes
Mar 9, 2020
hanshasselberg
approved these changes
Mar 9, 2020
| if ident != nil && ident.IsLocal() { | ||
| // Strip it from the request. | ||
| info.SetTokenSecret("") | ||
| defer info.SetTokenSecret(token) |
There was a problem hiding this comment.
I was wondering why we need to put it back, but then I saw that RPCInfo is an interface and interfaces are passed by reference.
rboyer
force-pushed
the
strip-local-tokens-on-forward
branch
from
f76c96d
to
7cedca7
Compare
…g datacenters Fixes #7414
This lets you forward an rpc to a remote dc with a remotely-local token
rboyer
force-pushed
the
strip-local-tokens-on-forward
branch
from
7cedca7
to
428cf7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7414
Note this is only the server-to-server side portion of 7414. The client-to-server change seems much more involved and seems like it has a higher likelihood of RPC amplification if not done with extreme care.