Automatically renew the token used by the Vault CA provider #8560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
reviewed
Aug 25, 2020
|
The other providers don't use a Vault token so there isn't a direct comparison. Renewing a token to extend the lease is pretty standard, though so I think there's a decent argument for it here, but there could also be a valid reason not to renew that I'm not seeing. |
dnephin
added
the
theme/certificates
dnephin
reviewed
Sep 10, 2020
There was a problem hiding this comment.
Nice! I think I am understanding this now. Mostly some minor suggestions for goroutine management and test cleanup.
I think the only real blocker is the handling of renewer.DoneCh().
I'm not sure why codecov is reporting that so many lines are not covered by tests, I confirmed they are.
|
@dnephin This is ready for another look when you get a chance, I addressed all the comments. |
rboyer
reviewed
Sep 15, 2020
rboyer
reviewed
Sep 15, 2020
kyhavlov
force-pushed
the
vault-ca-renew-token
branch
from
422bd9b
to
1cd7c43
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds logic to the Vault provider to renew the lease of the token automatically. It still needs a unit test, but I wanted to get feedback on whether we should make this configurable or just always enabled.