Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect: all config entries pick up a meta field #8596

Merged
merged 2 commits into from
Sep 2, 2020
Merged

connect: all config entries pick up a meta field #8596

merged 2 commits into from
Sep 2, 2020

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Sep 1, 2020

Fixes #8595

@rboyer rboyer requested review from lkysow, thisisnotashwin and a team September 1, 2020 19:38
@rboyer rboyer self-assigned this Sep 1, 2020
freddygv
freddygv approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@freddygv freddygv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, my only question is whether there's any reason why we shouldn't release it in 1.8.4 vs waiting for 1.9.0.

thisisnotashwin
thisisnotashwin approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up @rboyer

@rboyer rboyer merged commit 119e945 into master Sep 2, 2020
@rboyer rboyer deleted the config-entry-meta branch September 2, 2020 19:10
@hashicorp-ci
Copy link
Contributor

🍒❌ Cherry pick of commit 119e945 onto release/1.8.x failed! Build Log

@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit 119e945 onto release/1.8.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Sep 2, 2020
@rboyer @hashicorp-ci
connect: all config entries pick up a meta field (#8596)
770fc09 
Fixes #8595
@rboyer rboyer mentioned this pull request Sep 28, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddygv freddygv freddygv approved these changes

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@lkysow lkysow Awaiting requested review from lkysow

Assignees

@rboyer rboyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

config entries should have a general metadata field
4 participants
@rboyer @hashicorp-ci @freddygv @thisisnotashwin