Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-8728 add raft default values #8812

Merged
merged 2 commits into from
May 18, 2021
Merged

GH-8728 add raft default values #8812

merged 2 commits into from
May 18, 2021

Conversation

jjshanks
Copy link
Contributor

@jjshanks jjshanks commented Oct 3, 2020

Add raft default values to default config used by the agent endpoint.

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 3, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jsosulska jsosulska added the theme/internals Serf, Raft, SWIM, Lifeguard, Anti-Entropy, locking topics label Oct 5, 2020
freddygv
freddygv approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@freddygv freddygv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging May 18, 2021 18:51 Inactive
@vercel vercel bot temporarily deployed to Preview – consul May 18, 2021 18:51 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging May 18, 2021 19:04 Inactive
@vercel vercel bot temporarily deployed to Preview – consul May 18, 2021 19:04 Inactive
@dnephin
Copy link
Contributor

dnephin commented May 18, 2021

Added a changelog entry

@dnephin dnephin merged commit ce5ef18 into hashicorp:master May 18, 2021
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/370380.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit ce5ef18 onto release/1.10.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request May 18, 2021
@dnephin @hc-github-team-consul-core
Merge pull request #8812 from jjshanks/GH-8728
accc5db 
GH-8728 add raft default values
@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit ce5ef18 onto release/1.9.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request May 18, 2021
@dnephin @hc-github-team-consul-core
Merge pull request #8812 from jjshanks/GH-8728
181621b 
GH-8728 add raft default values
@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit ce5ef18 onto release/1.8.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request May 18, 2021
@dnephin @hc-github-team-consul-core
Merge pull request #8812 from jjshanks/GH-8728
ee992f7 
GH-8728 add raft default values
@jkirschner-hashicorp jkirschner-hashicorp mentioned this pull request Aug 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddygv freddygv freddygv approved these changes

Assignees
No one assigned
Labels
theme/internals Serf, Raft, SWIM, Lifeguard, Anti-Entropy, locking topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jjshanks @hashicorp-cla @dnephin @hc-github-team-consul-core @freddygv @jsosulska