agent: allow the /v1/connect/intentions/match endpoint to use the agent cache #8875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt cache This is the recommended proxy integration API for listing intentions which should not require an active connection to the servers to resolve after the initial cache filling.
28 tasks
freddygv
approved these changes
Oct 8, 2020
There was a problem hiding this comment.
LGTM, I think the remaining bits are: changelog and updating the agent caching mode in the docs:
https://github.com/hashicorp/consul/blob/master/website/pages/api-docs/connect/intentions.mdx#L513
I believe in this case it's background refresh like this catalog endpoint:
https://github.com/hashicorp/consul/blob/master/website/pages/api-docs/catalog.mdx#L446
Also it looks like /catalog/services and /catalog/datacenters should also have the agent caching updated. Those seem to be background refresh and simple based on their cache types.
|
I was going to handle the website updates for this over in the big catchall: #8869 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the recommended proxy integration API for listing intentions
which should not require an active connection to the servers to resolve
after the initial cache filling.