ACL tokens for service/check registration #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -160,6 +198,40 @@ func (l *localState) Services() map[string]*structs.NodeService { | |||
| return services | |||
| } | |||
|
|
|||
| // SetCheckToken is used to configure an ACL token for a specific | |||
| // health check. The token is used during check registration operations. | |||
| func (l *localState) SetCheckToken(id, token string) { | |||
There was a problem hiding this comment.
@ryanuber Can we roll this into the SetCheck? and also RemoveCheckToken into RemoveCheck?
|
LGTM! |
ryanuber
added a commit
that referenced
this pull request
May 6, 2015
ACL tokens for service/check registration
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
…rypt (hashicorp#891) Use consul-ca-cert when sync-catalog is enabled and autoencrypt is enabled but clients are disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows ACL tokens to be provided per service or check. This enables finer-grained ACL policies rather than requiring a "blanket" token configured on the agent.
Tokens can now be provided in configuration files (embedded in service and check definitions), or over the HTTP API by using the
?token=query parameter.Fixes #734