Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: deletions of intentions by name using the intention API is now idempotent #9278

Merged
merged 2 commits into from
Jan 4, 2021
Merged

server: deletions of intentions by name using the intention API is now idempotent #9278

merged 2 commits into from
Jan 4, 2021

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Nov 25, 2020

Restoring a behavior inadvertently changed while fixing #9254

@rboyer rboyer added this to the 1.9.x milestone Nov 25, 2020
@rboyer rboyer requested a review from a team November 25, 2020 20:41
@rboyer rboyer self-assigned this Nov 25, 2020
freddygv
freddygv approved these changes Nov 26, 2020
View reviewed changes
Copy link
Contributor

@freddygv freddygv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love returning a 200 for deletions on non-existent items, but I only just saw that we already do that elsewhere like for KV/Sessions.

Will save that bikeshed for API v2.

@rboyer rboyer merged commit d5d62d9 into master Jan 4, 2021
@rboyer rboyer deleted the ixn-new-deletes-idempotent branch January 4, 2021 17:27
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/303077.

hashicorp-ci pushed a commit that referenced this pull request Jan 4, 2021
@rboyer @hashicorp-ci
server: deletions of intentions by name using the intention API is no…
85205a6 
…w idempotent (#9278)

Restoring a behavior inadvertently changed while fixing #9254
@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit d5d62d9 onto release/1.9.x succeeded!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddygv freddygv freddygv approved these changes

Assignees

@rboyer rboyer

Labels
None yet
Projects
None yet
Milestone
1.9.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rboyer @hashicorp-ci @freddygv