[Streaming][bugfix] handle TLS signalisation when TLS is disabled on client side (alternative to #9494) #9512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…client side Tnis is an alternative to hashicorp#9494
pierresouchay
force-pushed
the
streaming_fix_grpc_tls2
branch
from
8a03283
to
e2f2d4b
Compare
dnephin
reviewed
Jan 6, 2021
This ensures that hashicorp#9474 will not reproduce.
pierresouchay
force-pushed
the
streaming_fix_grpc_tls2
branch
from
c5a2e3a
to
994fe80
Compare
dnephin
added
backport/1.9
theme/streaming
|
Those integration tests seem to be failing on master, so not related to this change. |
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/305585. |
|
🍒✅ Cherry pick of commit 326a312 onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Jan 6, 2021
[Streaming][bugfix] handle TLS signalisation when TLS is disabled on client side (alternative to #9494)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tnis is an alternative to #9494
We just patch the GRPC side, not everything as suggested by @dnephin