ui: Rename a model attribute to not be overwritten by ember-data #9524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxcode
force-pushed
the
ui/bug/error-service-instance-redirect
branch
from
c80a023
to
4467bd1
Compare
mmm, not sure. I rebased against master and force pushed. |
…ui/bug/error-service-instance-redirect
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/308810. |
|
🍒✅ Cherry pick of commit b86eea4 onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Jan 12, 2021
* Rename a model attr to not be overwritten by ember-data * Make sure we can click on the instances * Make sure we can click back to the preevious page, not root * Add a forwards/back/forwards navigation test for service instances * Rename a model attr to not be overwritten by ember-data Co-authored-by: John Cowen <jcowen@hashicorp.com>
johncowen
pushed a commit
that referenced
this pull request
Jan 20, 2021
johncowen
added a commit
that referenced
this pull request
Jan 20, 2021
hashicorp-ci
pushed a commit
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Clicking on a instance, then back, then clicking on the instance again would redirect users to a 404 error page.
Solution: There is a relationship between service-instance and proxy-instance models and they both have attr called
Node. In the service-instance modelNodeis an object and in the proxy-instance model it's a string. We expect a string at all times. To avoid overwriting we have renamedNodeto beNodeNamein the proxy-instance model.Test: Left a TODO note on the navigation tests. Unable to complete due to mock data.