ui: [BUGFIX] Replace all replaceAll with split.join for older browsers without replaceAll #9715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncowen
added
type/bug
|
🤔 Double check that this PR does not require a changelog entry in the .changelog directory. Reference |
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/326469. |
|
🍒✅ Cherry pick of commit eda38a0 onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Feb 11, 2021
…s without replaceAll (#9715) * ui: replace all `replaceAll` with split.join * Use a div instead of fieldset for flex-box reasons
dizzyup
pushed a commit
that referenced
this pull request
Apr 21, 2021
…s without replaceAll (#9715) * ui: replace all `replaceAll` with split.join * Use a div instead of fieldset for flex-box reasons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String.replaceAllis only available in newer browsers (for example after Chrome 85), so here we revert to usingsplit(find).join(replace)instead ofreplaceAll.A related CSS problem here was support for defining flex-box on fieldsets in older browsers. As this PR is a bugfix for 'older browsers' we added the fix for that here too.
Previous:
Fixes #9714
Thanks @r3knit !