ui: Adds warning icon to side menu when ACLs are disabled #9864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncowen
force-pushed
the
ui/feature/acls-status
branch
from
65509ee
to
fae3985
Compare
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/338566. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows a warning icon next to the Access Controls title of the side nav when ACLs are disabled to give an always on reminder that they are not enabled. We also show related unlinked navigation items which are visible but not clickable (Roles, Policies, Auth Methods). Tokens is still linked to give an area for us to provide further info.
When ACLs are enabled there is no change to how it was previously.
Worthwhile noting that we added a
(can "use acls")which should be used within templates moving forwards rather then(env "CONSUL_ACLS_ENABLED")- we should try to gradually phase out using theenvhelper from within templates, instead favouringcanfor permission/abilities andtfor text/copy/URLs.Both
canandthelpers are used widely in other product UIs whereasenvis not.