Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please provider a option to determine whether do escape or not when log in json format #140

Closed
Ericwww opened this issue Mar 30, 2024 · 2 comments · Fixed by #141
Closed

Please provider a option to determine whether do escape or not when log in json format #140

Ericwww opened this issue Mar 30, 2024 · 2 comments · Fixed by #141

Comments

@Ericwww
Copy link
Contributor

Ericwww commented Mar 30, 2024

Currently, when intLogger log in json format. It will call json.NewEncoder and do Encode.

But, the escapeHTML in json.Encoder is default to true. So when I want to log some info which will refer these symbol: &, <, and >, the log result is unexpected.

I would like to submit a PR to enhance it.
This was referenced Mar 30, 2024
Merged
Merged
@Ericwww
Copy link
Contributor Author

Ericwww commented Apr 1, 2024

@evanphx
Is there will be a new version release for this issue or PR?

@evanphx
Copy link
Contributor

evanphx commented Apr 1, 2024

@Ericwww Thanks for the reminder, push published 1.6.3 with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support configure json escape when log in json format Ericwww/go-hclog
2 participants
@evanphx @Ericwww