TestReap_ReapChildren fails randomly on x86_32 (unreliable test?)

[onlyjob]

TestReap_ReapChildren usually fails on i686 as follows:

--- FAIL: TestReap_ReapChildren (1.00s) 
        reap_unix_test.go:53: should have reaped 18206 

[onlyjob]

ping?

[tpot]

I'm pretty sure this is a race between the goroutine that calls ReapChildren() and hitting the select statement that pulls off the pids channel. I added a sleep after the goroutine to give it time to get started and the test hasn't failed in over an hour.

There's probably a nicer way to synchronise this though.

reap_unix_test_patch.txt

[slackpad]

Thanks @tpot I went ahead and took your patch via 04ce4d0. This test is a bit flaky because it does have some timeouts, so hopefully this will be good enough. If it continues to fail randomly we can look into a better synchronization mechanism.

[tpot]

Thanks @slackpad!