Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RFC1123 Date/Time in Retry-After header #144

Closed
justenwalker opened this issue Sep 20, 2021 · 0 comments · Fixed by #138
Closed

Support RFC1123 Date/Time in Retry-After header #144

justenwalker opened this issue Sep 20, 2021 · 0 comments · Fixed by #138
Milestone

Comments

@justenwalker
Copy link
Contributor

According to RFC7231
the Retry-After header may be specified in both number of seconds OR an HTTPDate

The value of this field can be either an HTTP-date or a number of seconds to delay after the response is received.

   Retry-After = HTTP-date / delay-seconds

A delay-seconds value is a non-negative decimal integer, representing time in seconds.

   delay-seconds  = 1*DIGIT

Two examples of its use are

  Retry-After: Fri, 31 Dec 1999 23:59:59 GMT
  Retry-After: 120

There are a couple PRs open to address this already.

Clearly there is some interest in supporting this aspect of the RFC. So just to close this out I think we'd either like to see:

  • One of the these PRs be accepted/merged
  • Communication that this feature is deliberately absent and will not be accepted. In this case, perhaps we could add comment in the code about that decision to dissuade future contributors from creating additional PRs for this feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants