Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add eof on template.yml #10

Closed
wants to merge 1 commit into from

Conversation

4geru
Copy link

@4geru 4geru commented Oct 27, 2021

Thanks to create great nextjs analizer.
My project introduced this github action.

Run npx -p nextjs-bundle-analysis generate to generate the file,
but the eof was missing. eof was missing in the original template file, so added it.

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 27, 2021

CLA assistant check
All committers have signed the CLA.

@4geru
Copy link
Author

4geru commented Dec 15, 2021

@jescalan please review this pull request 🙇

@jescalan
Copy link
Collaborator

Is there any specific reason that this is needed?

@4geru
Copy link
Author

4geru commented Dec 27, 2021

I add this template in my project and linter detect to add eof line.

@4geru 4geru closed this Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants