Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use actions/github-script to set comment body #29

Merged
merged 1 commit into from Feb 22, 2023
Merged

fix: use actions/github-script to set comment body #29

merged 1 commit into from Feb 22, 2023

Conversation

maxnowack
Copy link
Contributor

Setting action output using ::set-output was deprecated on 11th Oct 2022. See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ I've tried several approaches to switch to the new variant, but all of them have some kind of issues with multiline strings. So I tried something completely different and implemented it using actions/github-script.

Setting action output using `::set-output` was deprecated on 11th Oct 2022.
See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
I've tried several approaches to switch to the new variant, but all of them have some kind of issues with multiline strings.
So I tried something completely different and implemented it using `actions/github-script`.
@hashicorp-cla
Copy link

hashicorp-cla commented Nov 16, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@BRKalow BRKalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks!

@BRKalow BRKalow merged commit 7686d81 into hashicorp:main Feb 22, 2023
@maxnowack maxnowack deleted the patch-1 branch February 22, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants