Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consul Ingress Gateway config incorrectly requires Hosts value #10955

Closed
mikenomitch opened this issue Jul 27, 2021 · 1 comment · Fixed by #15749
Closed

Consul Ingress Gateway config incorrectly requires Hosts value #10955

mikenomitch opened this issue Jul 27, 2021 · 1 comment · Fixed by #15749

Comments

@mikenomitch
Copy link
Contributor

Nomad version

1.1.2

Issue

When configuring a Consul Ingress Gateway using Nomad, if you do not provide a "hosts" value, Nomad throws an error. The relevant code is here - https://github.com/hashicorp/nomad/blob/v1.1.2/nomad/structs/services.go#L1749-L1751

In the Consul documentation, it shows hosts as optional though: https://www.consul.io/docs/connect/config-entries/ingress-gateway#hosts - Have confirmed with the Consul team that this is accurate.

Additionally, the ingress example on the website doesn't include hosts, so it errors.

Reproduction steps

Expected Result

Job with consul ingress gateway deployed successfully.

Actual Result

Error Consul Ingress Service requires one or more hosts when using HTTP protocol ")

Job file

ingress {
    tls {
        enabled = false
    }
    listener {
        port     = 8080
        protocol = "http"
        service {
            name  = "freshrss"
            # hosts = ["freshrss.ingress.consul"] - fails unless this line is added
        }
    }
}
@mikenomitch mikenomitch changed the title Consul Ingress Gateway config requires Hosts value Consul Ingress Gateway config icorrectly requires Hosts value Oct 29, 2021
@blake blake changed the title Consul Ingress Gateway config icorrectly requires Hosts value Consul Ingress Gateway config incorrectly requires Hosts value Mar 1, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants