Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vault: set JobID in Vault metadata #11397

Merged
merged 3 commits into from Oct 27, 2021
Merged

vault: set JobID in Vault metadata #11397

merged 3 commits into from Oct 27, 2021

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented Oct 27, 2021

Closes: #11395 .

@notnoop notnoop requested a review from jrasell October 27, 2021 13:31
@notnoop notnoop self-assigned this Oct 27, 2021
jrasell
jrasell reviewed Oct 27, 2021
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to add "TaskGroup": a.TaskGroup, whilst adding metadata to cover the edge case where the same task exists in multiple groups within a job?

@vercel vercel bot temporarily deployed to Preview – nomad October 27, 2021 13:57 Inactive
jrasell
jrasell approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@notnoop notnoop merged commit 54ca97f into main Oct 27, 2021
@notnoop notnoop deleted the f-vault-metadata-jobid branch October 27, 2021 14:20
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrasell jrasell jrasell approved these changes

Assignees

@notnoop notnoop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vault: add job ID metadata when creating Vault tokens
2 participants
@notnoop @jrasell