Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: trim space of error response output #14145

Merged
merged 2 commits into from Aug 16, 2022
Merged

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented Aug 16, 2022

This PR does a strings.TrimSpace on the response body of a failed API request, so that an error response is not extended with unwanted whitespace.

before:

➜ nomad job run bad.nomad
Error submitting job: Unexpected response code: 500 (1 error occurred:
	* Task group cache validation failed: 1 error occurred:
	* Task group service validation failed: 1 error occurred:
	* Services are not unique: [group->foo]





)

after:

➜ nomad job run bad.nomad
Error submitting job: Unexpected response code: 500 (1 error occurred:
	* Task group cache validation failed: 1 error occurred:
	* Task group service validation failed: 1 error occurred:
	* Services are not unique: [group->foo])

@shoenig
Copy link
Member Author

shoenig commented Aug 16, 2022

Bonus update of golangci-lint because maybe it fixes the depguard failure 🤔

@shoenig shoenig marked this pull request as ready for review August 16, 2022 20:29
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants