Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fingerprint Windows Build Number #16591

Closed
schmichael opened this issue Mar 21, 2023 · 1 comment · Fixed by #17576
Closed

Fingerprint Windows Build Number #16591

schmichael opened this issue Mar 21, 2023 · 1 comment · Fixed by #17576

Comments

@schmichael
Copy link
Member

As of Nomad 1.5.1 the Windows version is fingerprinted into 2 attributes, but neither is a useful format:

kernel.version                           = 10.0.14393.5501 Build 14393.5501
...
os.version                               = 10.0.14393.5501 Build 14393.5501

Proposal

Include just the build number as a new fingerprinted attribute like:

os.build = 14393.5501

Such that constraints could treat it like a version number for comparisons.

Use-cases

Nomad 1.5 added the Task API as a unix socket. Windows only added Unix socket support in build 17063. In order to schedule tasks that expect the Task API on a version of Windows with unix socket support, we need to fingerprint the build number distinctly.

@tgross
Copy link
Member

tgross commented Jun 21, 2023

Done in #17576 which will ship in Nomad 1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants