drivers: make internal DisableLogCollection capability public
#17196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `DisableLogCollection` capability was introduced as an experimental interface for the Docker driver in 0.10.4. The interface has been stable and allowing third-party task drivers the same capability would be useful for those drivers that don't need the additional overhead of logmon. This PR only makes the capability public. It doesn't yet add it to the configuration options for the other internal drivers. Fixes: #14636 #15686
tgross
force-pushed
the
driver-api-disable-logging
branch
from
8085f69
to
e0143a3
Compare
pkazmierczak
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DisableLogCollectioncapability was introduced as an experimental interface for the Docker driver in 0.10.4. The interface has been stable for a while, and allowing third-party task drivers the same capability would be useful for those drivers that don't need the additional overhead of logmon.This PR only makes the capability public. It doesn't yet add it to the configuration options for the other internal drivers. (I'll do that in a separate PR just to keep review size reasonable.)
Fixes: #14636
Fixes: #15686
Unlike #16962 this has no visible impact on the jobspec or server state, but just to be sure I've tested upgrade paths on clients between 1.5.5 and this branch, both with and without the flag enabled on the
dockerdriver.