Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Add NetworkStatus to allocation response #17280

Merged
merged 2 commits into from Jul 4, 2023

Conversation

deverton-godaddy
Copy link
Contributor

Service discovery or mesh network systems consuming the Nomad event stream or API need to know the CNI assigned IP for the allocation. This data is returned by the underlying Nomad API but isn't mapped in the response struct in the Go client.

Service discovery or mesh network systems consuming the Nomad event stream or API need to know the CNI assigned IP for the allocation. This data is returned by the underlying Nomad API but isn't mapped in the response struct.
@hashicorp-cla
Copy link

hashicorp-cla commented May 23, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @deverton-godaddy!

I pushed a commit to add a CHANGELOG entry and a quick test. I also reordered the struct fields so it matches the order in structs.go, making it easier to finding missing fields (and I did notice some others missing here 😅)

Before we can merge this we will need you to sign the CLA. Would you be able to do that?

Thanks!

@lgfa29 lgfa29 added backport/1.3.x backport to 1.3.x release line backport/1.4.x backport to 1.4.x release line backport/1.5.x backport to 1.5.x release line stage/waiting-reply labels Jun 2, 2023
@lgfa29 lgfa29 moved this from Needs Triage to In Progress in Nomad - Community Issues Triage Jun 2, 2023
@deverton-godaddy
Copy link
Contributor Author

Thank you for taking the time to update this PR. I'm still working on getting CLA approval and will update as soon as I can. I'm hoping it should be in the next few days.

@deverton-godaddy
Copy link
Contributor Author

@lgfa29 I've signed the CLA so this should be good to go.

@lgfa29
Copy link
Contributor

lgfa29 commented Jul 4, 2023

@lgfa29 I've signed the CLA so this should be good to go.

Ops, sorry I missed this @deverton-godaddy. Thanks for handling the CLA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.3.x backport to 1.3.x release line backport/1.4.x backport to 1.4.x release line backport/1.5.x backport to 1.5.x release line stage/waiting-reply
Development

Successfully merging this pull request may close these issues.

None yet

3 participants