[ui] Text type to password type input on profile sign-in page #17345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Test Audit comparison
|
lgfa29
approved these changes
May 29, 2023
ChaiWithJai
approved these changes
May 30, 2023
philrenaud
force-pushed
the
16901-security-fr-uisettingstokens-input-field-type-as-password-to-guide-autofill-vs-password-manager-logic
branch
from
73f25e5
to
e1577ce
Compare
philrenaud
deleted the
16901-security-fr-uisettingstokens-input-field-type-as-password-to-guide-autofill-vs-password-manager-logic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16901
Changes ACL Token/JWT input field to be of type "password", enabling password managers and triggering browsers to store it sensitively.
I considered adding a "show token" button but opted against it for keeping overhead low.