Add check for missing path in client host_volume config
#17393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
reviewed
Jun 2, 2023
There was a problem hiding this comment.
Thanks for the PR @dttung2905!
I left a quick question there just to make sure I'm not missing anything.
command/agent/command.go
Outdated
| @@ -379,6 +379,15 @@ func (c *Command) IsValidConfig(config, cmdConfig *Config) bool { | |||
| return false | |||
| } | |||
|
|
|||
| if !reflect.ValueOf(config.Client.HostVolumes).IsZero() { | |||
There was a problem hiding this comment.
Is this condition necessary? If the list IsZero then the range below would be skipped anyway right?
There was a problem hiding this comment.
Hi @lgfa29,
Thanks for the super quick review! It is indeed redundant here .
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
dttung2905
force-pushed
the
fix-nomad-config-validate-host-volume
branch
from
95d03cf
to
cc7e3c4
Compare
lgfa29
approved these changes
Jun 5, 2023
lgfa29
pushed a commit
that referenced
this pull request
Jun 5, 2023
lgfa29
pushed a commit
that referenced
this pull request
Jun 6, 2023
…17433) Co-authored-by: Dao Thanh Tung <ttdao.2015@accountancy.smu.edu.sg>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team,
This PR aims to add additional check for missing
pathvalue in clienthost_volumeconfig. I have added 2 more test cases to validate this change. Please let me know if I need to make any additional changes for this 🙏Fixes : #16968