Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] New keyboard shortcut for Create Variable #17932

Merged
merged 1 commit into from Jul 20, 2023
Merged

[ui] New keyboard shortcut for Create Variable #17932

merged 1 commit into from Jul 20, 2023

Conversation

philrenaud
Copy link
Contributor

Now, from a variable page, you can type in n v, which stands for "NeVermind why I chose those letters"
image

@philrenaud philrenaud self-assigned this Jul 13, 2023
@philrenaud philrenaud mentioned this pull request Jul 13, 2023
Open
6 tasks
@github-actions
Copy link

github-actions bot commented Jul 13, 2023 •
edited

Ember Test Audit comparison

main 715764b change
passes 1498 1498 0
failures 1 1 0
flaky 0 0 0
duration 000ms 000ms -000ms

mikenomitch
mikenomitch approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@mikenomitch mikenomitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 - I like "n _" for "new ____" actions generally. For anything else we have create actions for. Policies, Jobs, Roles, Tokens?

@philrenaud philrenaud force-pushed the f-ui/keyboard-shortcuts-for-create-variable branch from 12f26dd to 715764b Compare July 20, 2023 16:38
@philrenaud philrenaud added the backport/1.6.x backport to 1.6.x release line label Jul 20, 2023
@philrenaud philrenaud merged commit 51393dd into main Jul 20, 2023
9 of 10 checks passed
@philrenaud philrenaud deleted the f-ui/keyboard-shortcuts-for-create-variable branch July 20, 2023 16:38
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Jul 20, 2023
Merged
jrasell pushed a commit that referenced this pull request Jul 26, 2023
@philrenaud @jrasell
Adds N V for variable creation as a keyboard shortcut (#17932)
e4ba14e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikenomitch mikenomitch mikenomitch approved these changes

@shoenig shoenig Awaiting requested review from shoenig

Assignees

@philrenaud philrenaud

Labels
backport/1.6.x backport to 1.6.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@philrenaud @mikenomitch