Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nomad native service health checks fail when using interpolated service address in job #18574

Closed
MattJustMatt opened this issue Sep 26, 2023 · 1 comment · Fixed by #18584
Closed

Nomad native service health checks fail when using interpolated service address in job #18574

MattJustMatt opened this issue Sep 26, 2023 · 1 comment · Fixed by #18584
Assignees
@jrasell
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/service-discovery/nomad theme/service-discovery type/bug
Projects
Nomad - Community Issues Triage

Comments

@MattJustMatt
Copy link
Contributor

MattJustMatt commented Sep 26, 2023 •
edited

Nomad version

1.6.2

Issue

Screenshot 2023-09-25 at 6 19 18 PM

Reproduction steps

  1. Use Nomad service discovery
  2. Set the address to a variable like the gce public IP address
  3. Add an HTTP health check

Expected Result

The health checker uses the variable address from the service catalog (/v1/service/:name output:)
Screenshot_2023-09-25_at_6 34 35_PM

Actual Result

The health checks always fail with a parse error (using the string literal value)

Job file (if appropriate)

Screenshot 2023-09-25 at 6 36 45 PM
@MattJustMatt MattJustMatt mentioned this issue Sep 26, 2023
Merged
@tgross tgross added this to Needs Triage in Nomad - Community Issues Triage via automation Sep 26, 2023
@jrasell jrasell added stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/service-discovery theme/service-discovery/nomad labels Sep 28, 2023
@jrasell jrasell self-assigned this Sep 28, 2023
@jrasell jrasell moved this from Needs Triage to Needs Roadmapping in Nomad - Community Issues Triage Sep 28, 2023
@jrasell
Copy link
Member

jrasell commented Sep 28, 2023

Hi @MattJustMatt and thanks for raising this issue along with the PR. I'll take another look at the PR, when I next have a moment.

Nomad - Community Issues Triage automation moved this from Needs Roadmapping to Done Oct 4, 2023
This was referenced Oct 4, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrasell jrasell

Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/service-discovery/nomad theme/service-discovery type/bug
Projects
Nomad - Community Issues Triage
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use interpolated address when performing health checks MattJustMatt/nomad
2 participants
@jrasell @MattJustMatt