We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nomad v1.6.2
Fedora 29
Nomad UI sends wrong request when purging.
Create a job not in default namespace. Stop it. Click to purge it.
Should be purged.
Not purged. When clicking "purge job" from the ui I see in chrome network debug view that it sends the following query:
<url>/v1/job/jobname?namespace=dev?purge=true
It's wrong, it should be namespace=dev&purge=true.
namespace=dev&purge=true
I completely guess, I know nothing about javascript, this is caused by adding ?purge here:
?purge
https://github.com/hashicorp/nomad/blob/main/ui/app/adapters/job.js#L47
Where the ?namespace is added here:
?namespace
https://github.com/hashicorp/nomad/blob/main/ui/app/adapters/watchable-namespace-ids.js#L54
The text was updated successfully, but these errors were encountered:
Hi @Kamilcuk , good find — seems we're not handling query params the right way here. Will look into a fix.
Sorry, something went wrong.
philrenaud
Successfully merging a pull request may close this issue.
Nomad version
Nomad v1.6.2
Operating system and Environment details
Fedora 29
Issue
Nomad UI sends wrong request when purging.
Reproduction steps
Create a job not in default namespace. Stop it. Click to purge it.
Expected Result
Should be purged.
Actual Result
Not purged.
When clicking "purge job" from the ui I see in chrome network debug view that it sends the following query:
It's wrong, it should be
namespace=dev&purge=true
.I completely guess, I know nothing about javascript, this is caused by adding
?purge
here:https://github.com/hashicorp/nomad/blob/main/ui/app/adapters/job.js#L47
Where the
?namespace
is added here:https://github.com/hashicorp/nomad/blob/main/ui/app/adapters/watchable-namespace-ids.js#L54
The text was updated successfully, but these errors were encountered: