consul: support admin partitions #19665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Consul Enterprise admin partitions. We added fingerprinting in #19485. This PR adds a `consul.partition` field. The expectation is that most users will create a mapping of Nomad node pool to Consul admin partition. But we'll also create an implicit constraint for the fingerprinted value. Fixes: #13139
tgross
force-pushed
the
consul-admin-partition-jobspec
branch
from
2a8ec44
to
0716ed7
Compare
gulducat
approved these changes
Jan 9, 2024
Yeah, that's somewhat complicated in that we can only support that in Consul ENT, which we don't have for all tests. But adding the partition where it's available would be nice. Will probably do that in a follow-up PR once I've got the ENT PR done. |
Juanadelacuesta
approved these changes
Jan 10, 2024
jrasell
approved these changes
Jan 10, 2024
nvanthao
pushed a commit
to nvanthao/nomad
that referenced
this pull request
Mar 1, 2024
Add support for Consul Enterprise admin partitions. We added fingerprinting in hashicorp#19485. This PR adds a `consul.partition` field. The expectation is that most users will create a mapping of Nomad node pool to Consul admin partition. But we'll also create an implicit constraint for the fingerprinted value. Fixes: hashicorp#13139
nvanthao
pushed a commit
to nvanthao/nomad
that referenced
this pull request
Mar 1, 2024
Add support for Consul Enterprise admin partitions. We added fingerprinting in hashicorp#19485. This PR adds a `consul.partition` field. The expectation is that most users will create a mapping of Nomad node pool to Consul admin partition. But we'll also create an implicit constraint for the fingerprinted value. Fixes: hashicorp#13139
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Consul Enterprise admin partitions. We added fingerprinting in #19485. This PR adds a
consul.partitionfield. The expectation is that most users will create a mapping of Nomad node pool to Consul admin partition. But we'll also create an implicit constraint for the fingerprinted value.Fixes: #13139