vault: add new nomad setup vault -check commmand
#19720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new `nomad setup vault -check` commmand can be used to retrieve information about the changes required before a cluster is migrated from the deprecated legacy authentication flow with Vault to use only workload identities.
shoenig
reviewed
Jan 11, 2024
shoenig
reviewed
Jan 11, 2024
shoenig
reviewed
Jan 11, 2024
|
|
||
| // Verify only jobs without Vault identity are returned. | ||
| must.Len(t, 2, resp.JobsWithoutVaultIdentity) | ||
| must.SliceContains(t, resp.JobsWithoutVaultIdentity, jobNoWID.Stub(nil, nil), must.Cmp(cmpopts.IgnoreFields( |
There was a problem hiding this comment.
I knew somebody would use must.Cmp one day!! 🥳
There was a problem hiding this comment.
I've used them a in a few places while working on node pools. Very handy for ignoring these Raft indexes that we usually don't care about 😄
https://github.com/search?q=repo%3Ahashicorp%2Fnomad%20%22must.Cmp%22&type=code
shoenig
reviewed
Jan 11, 2024
|
|
||
| // MinNomadVersionVaultWID is the minimum version of Nomad that supports | ||
| // workload identities for Vault. | ||
| MinNomadVersionVaultWID = version.Must(version.NewVersion("1.7.0-a")) |
There was a problem hiding this comment.
is the 1.7.0-a literal correct? (which I guess could make sense as -a is the first possible pre-release version in semver 2)
There was a problem hiding this comment.
Ah yes, I should've copied this info from the implicit constraint:
nomad/nomad/job_endpoint_hook_implicit_identities.go
Lines 53 to 59 in b2aa6ff
shoenig
reviewed
Jan 11, 2024
nvanthao
pushed a commit
to nvanthao/nomad
that referenced
this pull request
Mar 1, 2024
The new `nomad setup vault -check` commmand can be used to retrieve information about the changes required before a cluster is migrated from the deprecated legacy authentication flow with Vault to use only workload identities.
nvanthao
pushed a commit
to nvanthao/nomad
that referenced
this pull request
Mar 1, 2024
The new `nomad setup vault -check` commmand can be used to retrieve information about the changes required before a cluster is migrated from the deprecated legacy authentication flow with Vault to use only workload identities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
nomad setup vault -checkcommmand can be used to retrieve information about the changes required before a cluster is migrated from the deprecated legacy authentication flow with Vault to use only workload identities.