Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update consul-template to 0.37.4 to fix resource leak #20234

Merged
merged 1 commit into from Mar 27, 2024

Conversation

tgross
Copy link
Member

@tgross tgross commented Mar 27, 2024

A Nomad user reported an issue where template runner View.poll goroutines were being leaked when using templates with many dependencies. This resource leak was fixed in consul-template 0.37.4.

Fixes: #20163

A Nomad user reported an issue where template runner `View.poll` goroutines were
being leaked when using templates with many dependencies. This resource leak was
fixed in consul-template 0.37.4.

Fixes: #20163
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🕷️

@tgross tgross added backport/1.5.x backport to 1.5.x release line backport/1.6.x backport to 1.6.x release line backport/1.7.x backport to 1.7.x release line labels Mar 27, 2024
@tgross tgross added this to the 1.7.x milestone Mar 27, 2024
@tgross tgross merged commit c3e7b13 into main Mar 27, 2024
25 checks passed
@tgross tgross deleted the deps-consul-template branch March 27, 2024 15:51
tgross added a commit that referenced this pull request Mar 27, 2024
A Nomad user reported an issue where template runner `View.poll` goroutines were
being leaked when using templates with many dependencies. This resource leak was
fixed in consul-template 0.37.4.

Fixes: #20163
tgross added a commit that referenced this pull request Mar 27, 2024
A Nomad user reported an issue where template runner `View.poll` goroutines were
being leaked when using templates with many dependencies. This resource leak was
fixed in consul-template 0.37.4.

Fixes: #20163
tgross added a commit that referenced this pull request Mar 27, 2024
A Nomad user reported an issue where template runner `View.poll` goroutines were
being leaked when using templates with many dependencies. This resource leak was
fixed in consul-template 0.37.4.

Fixes: #20163
tgross added a commit that referenced this pull request Mar 27, 2024
A Nomad user reported an issue where template runner `View.poll` goroutines were
being leaked when using templates with many dependencies. This resource leak was
fixed in consul-template 0.37.4.

Fixes: #20163
philrenaud pushed a commit that referenced this pull request Apr 18, 2024
A Nomad user reported an issue where template runner `View.poll` goroutines were
being leaked when using templates with many dependencies. This resource leak was
fixed in consul-template 0.37.4.

Fixes: #20163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.5.x backport to 1.5.x release line backport/1.6.x backport to 1.6.x release line backport/1.7.x backport to 1.7.x release line theme/consul-template theme/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

goroutine leak in template runner
2 participants