[ui] Show re-bound keyboard nav hints instead of their default values #20235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember Test Audit comparison
|
philrenaud
commented
Mar 27, 2024
| @@ -110,6 +111,7 @@ export default class KeyboardService extends Service { | |||
| { | |||
| label: 'Go to Variables', | |||
| action: () => this.router.transitionTo('variables'), | |||
| rebindable: true, | |||
There was a problem hiding this comment.
Side-effect: the "go to variables" key command wasn't re-bindable! I must've forgotten during Vars work.
philrenaud
force-pushed
the
20232-ui-bug-keyboard-nav-re-binding-doesnt-show-up-in-hints-with-shift
branch
from
5d1dfb6
to
a0cf98f
Compare
philrenaud
force-pushed
the
20232-ui-bug-keyboard-nav-re-binding-doesnt-show-up-in-hints-with-shift
branch
from
a0cf98f
to
76a7229
Compare
ui/app/services/keyboard.js
Outdated
| @@ -209,6 +212,12 @@ export default class KeyboardService extends Service { | |||
| }); | |||
| } | |||
|
|
|||
| getCommandByPattern(pattern) { | |||
There was a problem hiding this comment.
I don't see where is this one used
There was a problem hiding this comment.
Good catch, this is an orphaned method from my first attempt at solving this. Thank you for spotting it!
Juanadelacuesta
approved these changes
Apr 2, 2024
philrenaud
deleted the
20232-ui-bug-keyboard-nav-re-binding-doesnt-show-up-in-hints-with-shift
branch
philrenaud
added a commit
that referenced
this pull request
Apr 18, 2024
…#20235) * Rebinds show up as soon as you start rebinding * Hint bind and rebind tests * Orphaned getCommandByPattern method removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Nomad UI, you can re-bind your keyboard shortcuts (from
g jtojobto go to the jobs route, for example).But prior to this PR, whether or not you'd re-bound a key command, the hint that would show up when holding
shiftwould always be the default. This is because the hints are generated via{{keyboard-shortcut}}modifier, and are separate from the list of the keyboard service'sdefaultCommandslist.This PR does a lookup on
get hints(), which fires every time the user holdsshift.