Worker waits til max ModifyIndex across EvalsByJob #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armon
reviewed
Sep 13, 2017
nomad/eval_endpoint.go
Outdated
| // Get the index that the worker should wait until before scheduling. | ||
| waitIndex, err := e.getWaitIndex(eval.Namespace, eval.JobID) | ||
| if err != nil { | ||
| return err |
armon
reviewed
Sep 13, 2017
| return 0, err | ||
| } | ||
|
|
||
| evals, err := snap.EvalsByJob(nil, namespace, job) |
There was a problem hiding this comment.
Why not use an iterator to avoid materializing the slice?
dadgar
force-pushed
the
b-eval-index
branch
from
31a4cd0
to
1109a72
Compare
This PR fixes a scheduling race condition in which the plan results from one invocation of the scheduler were not being considered by the next since the Worker was not waiting for the correct index. Fixes #3198
dadgar
force-pushed
the
b-eval-index
branch
from
1109a72
to
eae982d
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a scheduling race condition in which the plan results from
one invocation of the scheduler were not being considered by the next
since the Worker was not waiting for the correct index.
Fixes #3198