Set user for rkt tasks #3612
Set user for rkt tasks #3612
Conversation
client/driver/docker.go
Outdated
| @@ -201,6 +201,7 @@ type DockerDriverConfig struct { | |||
| MacAddress string `mapstructure:"mac_address"` // Pin mac address to container | |||
| SecurityOpt []string `mapstructure:"security_opt"` // Flags to pass directly to security-opt | |||
| Devices []DockerDevice `mapstructure:"devices"` // To allow mounting USB or other serial control devices | |||
| User string `json:"User,omitempty" yaml:"User,omitempty" toml:"User,omitempty"` | |||
There was a problem hiding this comment.
whats up with the yaml and toml here?
chelseakomlo
changed the title
|
Testing suggestions are more than welcome. |
client/driver/docker.go
Outdated
| @@ -201,6 +201,7 @@ type DockerDriverConfig struct { | |||
| MacAddress string `mapstructure:"mac_address"` // Pin mac address to container | |||
| SecurityOpt []string `mapstructure:"security_opt"` // Flags to pass directly to security-opt | |||
| Devices []DockerDevice `mapstructure:"devices"` // To allow mounting USB or other serial control devices | |||
| User string `mapstructure:user` | |||
There was a problem hiding this comment.
Why add a new config field instead of using the task.User?
chelseakomlo
force-pushed
the
docker-rkt-user
branch
from
e59d8f8
to
23b7042
Compare
|
Changed this as we already expose this functionality for Docker, see https://www.nomadproject.io/docs/job-specification/task.html#user. Added the change to pass this through for rkt. |
| @@ -569,6 +569,11 @@ func (d *RktDriver) Start(ctx *ExecContext, task *structs.Task) (*StartResponse, | |||
|
|
|||
| } | |||
|
|
|||
| // If a user has been specified for the task, pass it through to the user | |||
There was a problem hiding this comment.
See if you can add tests to this and for docker
|
|
||
| select { | ||
| case res := <-resp.Handle.WaitCh(): | ||
| assert.False(res.Successful()) |
There was a problem hiding this comment.
Can you assert it fails b/c the user
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Further testing is necessary for each case