Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build failure on macOS #7354

Closed
tgross opened this issue Mar 16, 2020 · 1 comment · Fixed by #7355
Closed

build failure on macOS #7354

tgross opened this issue Mar 16, 2020 · 1 comment · Fixed by #7355
Labels
theme/dependencies Pull requests that update a dependency file type/bug

Comments

@tgross
Copy link
Member

tgross commented Mar 16, 2020

Following the merge of #7347, builds fail on macOS because of missing vendored cgo dependencies in the upstream gopsutil library: shirou/gopsutil#832.

▶ make dev
--> Formatting vendor/vendor.json
test -x /Users/tim/go/bin/vendorfmt || go get -u github.com/magiconair/vendorfmt/cmd/vendorfmt
vendorfmt
Formatted vendor/vendor.json
--> Making [GH-xxxx] references clickable...
--> Formatting HCL
==> Removing old development build...
==> Building pkg/darwin_amd64/nomad with tags ui ...
# github.com/hashicorp/nomad/vendor/github.com/shirou/gopsutil/host
vendor/github.com/shirou/gopsutil/host/host_darwin_cgo.go:9:11: fatal error: 'include/smc.c' file not found
 #include "include/smc.c"
          ^~~~~~~~~~~~~~~
1 error generated.
make[1]: *** [pkg/darwin_amd64/nomad] Error 2
make: *** [dev] Error 2

@notnoop we can hack around this until we can get it patched in upstream by vendoring in the contents of https://github.com/shirou/gopsutil/tree/master/host/include directly, but I suspect that's going to make govendor's checksumming unhappy?

@tgross tgross added theme/dependencies Pull requests that update a dependency file type/bug labels Mar 16, 2020
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/dependencies Pull requests that update a dependency file type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant