Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove copying of CGO files #8102

Closed
shoenig opened this issue Jun 3, 2020 · 2 comments
Closed

remove copying of CGO files #8102

shoenig opened this issue Jun 3, 2020 · 2 comments
Assignees
@notnoop
Labels
theme/cleanup theme/dependencies Pull requests that update a dependency file

Comments

@shoenig
Copy link
Member

shoenig commented Jun 3, 2020

Once shirou/gopsutil#885 and/or shirou/gopsutil#832 is complete,

  • Remove lib/darwin
  • Remove:
# Copy CGO files for darwin into place
#   TODO(shoenig) remove pending github.com/shirou/gopsutil/pull/885
$(shell cp -R lib/darwin/include vendor/github.com/shirou/gopsutil/host)

from GNUMakefile.
@shoenig shoenig added theme/cleanup theme/dependencies Pull requests that update a dependency file labels Jun 3, 2020
@shoenig
Copy link
Member Author

shoenig commented Jun 4, 2020

fixed in #8108

@shoenig shoenig closed this as completed Jun 4, 2020
@github-actions
Copy link

github-actions bot commented Nov 6, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@notnoop notnoop

Labels
theme/cleanup theme/dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@notnoop @shoenig