Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the network_speed unit #9385

Closed
rgl opened this issue Nov 18, 2020 · 5 comments · Fixed by #9685
Closed

Document the network_speed unit #9385

rgl opened this issue Nov 18, 2020 · 5 comments · Fixed by #9685
Labels
theme/docs Documentation issues and enhancements theme/networking

Comments

@rgl
Copy link

rgl commented Nov 18, 2020

Can you please document the unit that is used https://www.nomadproject.io/docs/configuration/client#network_speed?

I can alternatively submit a PR when you tell me what is the unit :-)

Nomad version

Nomad v1.0.0-beta3 (fcb32ef)

@tgross
Copy link
Member

tgross commented Nov 19, 2020

Hi @rgl! That's in mbits. But just a heads up that the jobspec field that consumes that value has been deprecated but not yet entirely removed (see #8681)

@tgross tgross added theme/docs Documentation issues and enhancements theme/networking labels Nov 19, 2020
@rgl
Copy link
Author

rgl commented Nov 19, 2020

Does that mean it no longer has any effect?

@nh2
Copy link
Contributor

nh2 commented Jan 13, 2021

network_speed is still used in the tutorial's default config:

https://www.nomadproject.io/docs/configuration

client {
  enabled       = true
  network_speed = 10
}

But it's not documented anywhere what unit that is.

@tgross Is it only removed from the jobspec, or should it also be removed from the agent config?

@tgross
Copy link
Member

tgross commented Jan 13, 2021

We removed it from the docs in #9685 but missed the example. I'll remove that. Thanks!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/docs Documentation issues and enhancements theme/networking
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants