New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand .gitignore #67

Closed

ethanmdavidson opened this issue Mar 3, 2022 · 0 comments

ethanmdavidson commented Mar 3, 2022

I have a plugin created from this scaffolding, and ended up adding the following rules to the .gitignore:

**/packer_log*.txt
**/git_*test.pkr.hcl
crash.log
.docs
docs.zip

Reasoning:

**/packer_log*.txt and **/git_*test.pkr.hcl match the files generated by a failed acceptance test run
crash.log file is created when packer crashes
.docs folder is now created by make generate, and it's my understanding that this is just for previewing locally and doesn't need to be checked in, though I might be misunderstanding how the plugin docs gets built into the website.
docs.zip is a build artifact

IMO these should all be part of the scaffolding here.

The text was updated successfully, but these errors were encountered:

nywilken closed this as completed in

52692bd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment