Adds support for building with the VMWare Workstation Pro API #161
Conversation
Address the following CVEs: - CVE-2023-39325 - CVE-2023-44487 - CVE-2023-3978 Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
Address the following CVE: - CVE-2023-44487 Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
- Bumps `github.com/vmware/govmomi` from 0.29.0 to 0.33.1. - Added github.com/vmware/govmomi to dependabot dependency checks. Signed-off-by: Ryan Johnson <johnsonryan@vmware.com>
|
|
Updated expected error value in "Invalid remote type" and updated expected default in "Set default values". Note: driver_config.go was updated to only set exsi-relevant defaults is esx5 is selected
Fixes all issues in driver_vmrest.go identified by golangci-lint
Fixes the two-line discrepancy identified by CI
|
All issues identified by the first round of checks should be addressed. There were three categories of issues:
I've also re-run my live test of the vmrest builder to ensure changes did not affect functionality |
| ### SSH key pair automation | ||
| ### Building with the VMWare Workstation Pro API (vmrest) | ||
|
|
||
| VMWare Workstation Pro ships with a 'vmrest' executable enabling programmatic |
There was a problem hiding this comment.
"VMware" for all occurrences of "VMWare", please.
There was a problem hiding this comment.
Thank you for the review! I've corrected "VMWare" to "VMware" in all instances where I wrote the former.
(Note: I did not make the change for instances of "VMWare" that preexisted my contribution)
|
@tenthirtyam Since you were kind enough to review - do you know if there are additional steps I should be taking and/or reviewers I should be talking to? This has been slow to take off, and I want to make sure I'm doing my due diligence. The members of my team that need this functionality are already using a fork, but it would be nice to have this in the official plugin. |
|
@tenthirtyam we will throw some time on your calendar to sync up on this change before starting to review. |
As described in #157:
Creates a new driver for vmrest, the API that ships with VMWare Workstation Pro. Due to limitations in the API, only the vmware-vmx builder can be implemented.
Checks have been added to the vmware-iso builder to throw an explanatory error if a user mistakenly tries to use the vmrest remote_type. Additional checks have been added to throw errors if incompatible configurations are set while using the vmrest remote_type.
The vmware-vmx documentation was also updated.
A test for the new driver has been provided in #157.
Closes #157