Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Disk created with Public Endpoint, no option to make it private #10535

Closed
NickLarsenNZ opened this issue Jan 27, 2021 · 3 comments
Closed
Labels
enhancement remote-plugin/azure stage/waiting-on-upstream This issue is waiting on an upstream change

Comments

@NickLarsenNZ
Copy link

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request.
If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

Using the azure-arm builder, a Disk is created with "Public Endpoint" enabled, even when building on a private network.
image

It would be great to have a config option to make it private (and make that the default).

Use Case(s)

Organisations with controls to prevent public disks being created.

Potential configuration

Either add an option to allow the disk to be public, but default to private:

   "builders": [
        {
            "type": "azure-arm",
            ...
            "pubic_disk_access": true
        }
   ]

Or, hard code it to private (I can't think of a case where it would need to be public).

Maybe even the "Deny All" option would work, I'm not quite sure if private access is even required for mounting the disk to a VM.

Potential References

@NickLarsenNZ
Copy link
Author

Having looked a bit deeper, I can't even see how to change that setting via the Azure API. Maybe a Disk needs to be specifically created, and attached to the VM.

@ghost
Copy link

ghost commented Apr 30, 2021

This issue has been automatically migrated to hashicorp/packer-plugin-azure#52 because it looks like an issue with that plugin. If you believe this is not an issue with the plugin, please reply to hashicorp/packer-plugin-azure#52.

@ghost ghost closed this as completed Apr 30, 2021
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement remote-plugin/azure stage/waiting-on-upstream This issue is waiting on an upstream change
Projects
None yet
Development

No branches or pull requests

3 participants