Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ProtocolVersion to ReattachConfig #182

Merged
merged 1 commit into from
May 27, 2021
Merged

Conversation

kmoe
Copy link
Member

@kmoe kmoe commented May 25, 2021

As of go-plugin v1.4.1, the reattach config now contains protocol version information so that protocol version can be negotiated during reattach. Please see hashicorp/go-plugin#171.

As of go-plugin v1.4.1, the reattach config now contains protocol version information so that protocol version can be negotiated during reattach. Please see hashicorp/go-plugin#171.
Copy link
Contributor

@paddycarver paddycarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM 🚀

@kmoe kmoe merged commit 53cc7f2 into main May 27, 2021
@kmoe kmoe deleted the reattach-config-protocolversion branch May 27, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants