Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for terraform add command #232

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Remove support for terraform add command #232

merged 1 commit into from
Oct 27, 2021

Conversation

kmoe
Copy link
Member

@kmoe kmoe commented Oct 21, 2021

closes #230

The terraform add command was introduced in certain Terraform v1.1.0 alpha releases in order to gather feedback. It has now been removed from Core (hashicorp/terraform#29782).

Support in tfexec for terraform add was included in the same experimental vein, with a doc comment indicating that it may be removed. Removal of Add() is therefore not a breaking change for tfexec.

This PR also removes FromStateOption and IncludeOptionalOption, which were only used in Add().

@kmoe kmoe requested a review from radeksimko October 21, 2021 14:59
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🚀

The terraform add command was introduced in certain Terraform v1.1.0 alpha
releases in order to gather feedback. It has now been removed from Core.

Support in tfexec for terraform add was included in the same experimental vein,
with a doc comment indicating that it may be removed. Removal of Add() is
therefore not a breaking change for tfexec.
@kmoe kmoe merged commit e2752b2 into main Oct 27, 2021
@kmoe kmoe deleted the remove-add branch October 27, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove terraform add
2 participants