Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make import paths match package names. #7

Merged
merged 1 commit into from Aug 16, 2021

Conversation

paddycarver
Copy link
Contributor

If we don't make import paths match package names, goimports has a hard
time finding them and they need to be typed out by hand, which is very
annoying and adds unnecessary friction.

Fixes #5.

If we don't make import paths match package names, goimports has a hard
time finding them and they need to be typed out by hand, which is very
annoying and adds unnecessary friction.
@paddycarver paddycarver requested a review from a team August 16, 2021 14:56
@bflad bflad self-assigned this Aug 16, 2021
@bflad bflad added this to the v0.2.0 milestone Aug 16, 2021
Copy link
Member

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@bflad bflad removed their assignment Aug 16, 2021
@paddycarver paddycarver merged commit 6a9db68 into main Aug 16, 2021
@paddycarver paddycarver deleted the paddy_match_package_names branch August 16, 2021 15:34
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make package names match import paths
2 participants