Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-configure providers during binary acctests #355

Merged
merged 2 commits into from
Mar 15, 2020
Merged

Conversation

kmoe
Copy link
Member

@kmoe kmoe commented Mar 13, 2020

Fixes #352.

This runs Configure() on providers prior to the binary acctest run, so they can access provider.Meta() during tests.

The one nuance to be aware of here is that PreCheck() is called after the auto-configure, in case providers are already using this for custom configuration.

Note

Once this is approved I'll generate CHANGELOG and raise another PR to the version2 branch.

@kmoe kmoe requested a review from appilon March 13, 2020 17:06
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is sort of diverged in V2 (there's no else case). Not sure if that lands just in another PR or via cherry picks? Defer to your git expertise on how to make this go the cleanest, I just wanna avoid conflicts the day we PR version2 into master.

@kmoe
Copy link
Member Author

kmoe commented Mar 13, 2020

I'll just raise another PR to version2 manually - no need for git magic here as it's a simple change.

@kmoe kmoe merged commit d3b1ac9 into master Mar 15, 2020
@kmoe kmoe deleted the auto-configure-acctest branch March 15, 2020 22:30
@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binary Test Driver: Unconfigured Provider Global
2 participants