Set default TerraformVersion

[appilon]

if the provider is served over the 0.12 protocol it will have a TerraformVersion set. If it is serving the old protocol it will be unset. This is to avoid a piece of boilerplate from repeating over and over in provider ConfigureFuncs, and ensure a consistent special designation of 0.11+compatible, implying it was TF 0.10/0.11 (0.11 compatible/protocol 4).

I originally wanted to try and set this up in the protocol 4 parts of the code... but I couldn't track it down and plumbing it through might be a pain. The risk with this implementation is it feels awkward to mutate the provider struct at this point, are we sure we never want to access this variable before Configure is invoked? I'm not a lifecycle/architecture expert yet.

[radeksimko]

It seems to be working (tested with 0.11 + AWS provider). I can't remember why I haven't done that in core. 🤔

[apparentlymart]

I believe we decided to leave this unset for older versions so that in principle the provider could differentiate an unknown version from a known one, but this special sigil value that would never be generated by a real version of Terraform can serve that purpose too, as long as all the consumers know that if they see this string it could be Terraform 0.10.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.